Conversation
…22539] Thirteen tracked files tripped the repository's end-of-file-fixer pre-commit hook because they ended with excess trailing blank lines rather than a single newline, so `pre-commit run --all-files` kept reporting them as "Fixing ...". The four docs/*.md files ended with multiple blank lines and the nine helpdesk/mixins __init__.py package markers each held a single blank line. Normalize every file to the hook's rule: end with exactly one newline, or be empty for the otherwise-empty package markers. This is pure end-of-file whitespace normalization. File bodies are byte-identical up to the trailing whitespace and there is no behavior change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Important Review skippedNo new commits to review since the last review. ⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughFour documentation files are updated: trailing blank lines are removed from ChangesDocumentation cleanup
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai approve |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
✅ Action performedComments resolved and changes approved. |
jentyk
deleted the
feature/MPT-22539/normalize-trailing-newlines-on-files-failing-end-file-fixer-pre-commit-hook
branch
2 participants
🤖 AI-generated PR — Please review carefully.
What
Normalize end-of-file whitespace on the 13 tracked files that fail the repository's
end-of-file-fixerpre-commit hook.docs/*.mdfiles ended with multiple trailing blank lines.__init__.pypackage markers each held a lone blank line.end-of-file-fixerenforces "ends with exactly one newline, or is empty", so this trims the docs files to a single trailing newline and reduces the empty package markers to 0 bytes.Why
uv run pre-commit run --all-filesreported all 13 files asFixing ...on every run, leaving a dirty worktree and noise for anyone running the hooks locally. Pure repo hygiene — no behavior change.Notes for reviewers
HEAD). The diff is 21 deletions, 0 insertions.__init__.pyfiles become 0 bytes — still valid, empty Python package markers.uv run pre-commit run end-of-file-fixer --all-filespasses clean.Jira: MPT-22539
Closes MPT-22539
end-of-file-fixerpre-commit hookdocs/e2e_tests.md,docs/local-development.md,docs/rql.md,docs/unit_tests.md) to end with a single trailing newline__init__.pypackage markers in test directories to 0 bytesend-of-file-fixerhook that was leaving the worktree dirty